Allow concat to take non-array second parameters #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also improve and extend concat tests to lock down functionality
apenney
pushed a commit
that referenced
this pull request
Apr 24, 2014
Allow concat to take non-array second parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the concat command to take any object type as the second parameter. It should preserve existing functionality.
I have also expanded upon the existing tests to lock down the current functionality.
I initially used
.concat(x).flatten!, but realised that if somebody is passing nested arrays as the second parameter then this change will break their existing functionality. A test case was added to ensure this behaviour is preserved for future changes.As per the contributing guidelines I have signed the contributing agreement and signed up to JIRA, but see no JIRA project for puppet-stdlib. I raised a question about this on the freenode IRC channel but got no response.
Please advise if I've missed anything.