Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated file_line docs for accuracy and non-badness. #331

Closed
wants to merge 1 commit into from
Closed

Updated file_line docs for accuracy and non-badness. #331

wants to merge 1 commit into from

Conversation

big-samantha
Copy link

The file_line with match example was broken, because the match
didn't match the line.

In addition, it was a bad example, because it shows using file_line to
modify /etc/fstab, which should really be done with the mount
provider.

In addition, the text didn't explain fully how to use match.

The `file_line` with `match` example was broken, because the `match`
didn't match the `line`.

In addition, it was a bad example, because it shows using `file_line` to
modify `/etc/fstab`, which should really be done with the motunt
provider.

In addition, the text didn't explain fully how to use match.
@raphink
Copy link
Contributor

raphink commented Oct 27, 2014

Arguably, this example is not really good either, as it could be done with the shellvar type:

shellvar { 'HTTP_PROXY':
  ensure  => exported,
  value   => 'http://squid.puppetlabs.vm:3128',
  target  => '/etc/bashrc',
}

@big-samantha
Copy link
Author

Hmm, I'm not sure I agree. I don't exactly disagree, but the shellvar type is not a built int type, and so this example seems fine to me. That being said, I'm open to an alternative suggestion :)

@igalic
Copy link
Contributor

igalic commented Oct 28, 2014

if you aren't using shellvar, you totally should ;)

@DavidS
Copy link
Contributor

DavidS commented May 28, 2015

The current example edits /etc/sudoers and does not use match at all, so I'm closing this.

@DavidS DavidS closed this May 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants