Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding markdown for the range() function's 3rd argument #410

Merged
merged 1 commit into from Mar 4, 2015

Conversation

robruma
Copy link
Contributor

@robruma robruma commented Feb 12, 2015

This documents the feature added in #56

@igalic
Copy link
Contributor

igalic commented Feb 16, 2015

👍

@underscorgan
Copy link
Contributor

Hi @robruma, thanks for the contribution! Could you rebase this against master so it only contains the one commit with your changes? Thanks!

@robruma
Copy link
Contributor Author

robruma commented Mar 4, 2015

@mhaskel Hopefully this is what you expected, please let me know if you'd rather me squash all the changes... Thanks

@underscorgan
Copy link
Contributor

@robruma We'd like this to be a squashed down to a single commit before we merge it (and it shouldn't have all the merge commits it has now)

Adding markdown for the range() function's 3rd argument

Adding markdown for the range() function's 3rd argument
@robruma robruma force-pushed the range_documentation_update branch from 3b9fb8a to 380cb02 Compare March 4, 2015 23:03
@robruma
Copy link
Contributor Author

robruma commented Mar 4, 2015

@mhaskel sorry for the delay, hopefully this commit is satisfactory. Thanks

underscorgan pushed a commit that referenced this pull request Mar 4, 2015
Adding markdown for the range() function's 3rd argument
@underscorgan underscorgan merged commit 20d4939 into puppetlabs:master Mar 4, 2015
@underscorgan
Copy link
Contributor

Looks good, thanks @robruma !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants