Ticket/MODULES-2478 Make root_home fact work on AIX using native lsuser command #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| setcode do | ||
| str = Facter::Util::Resolution.exec("lsuser -C -a home root") | ||
| str && str.split("\n").each do |line| | ||
| next if line =~ /#/ |
There was a problem hiding this comment.
Given your example, this should probably be matching /^#/ ? Not that I expect any sane person to have a hash in its root directory ...
There was a problem hiding this comment.
Good spot, done, thanks.
|
Hi Jon, thanks for your contribution! If you could squash that into a single commit, it would be grand to keep the git history clean. Cheers, David See https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History#Squashing-Commits |
Squashed, and amended test for comment lines.
jfautley
force-pushed
the
ticket/MODULES-2478-support_root_home_fact_on_AIX
branch
from
ac82828
to
6c2a003
Compare
|
Commits squashed into one, and comment-line match fixed. |
DavidS
added a commit
that referenced
this pull request
Sep 1, 2015
…t_home_fact_on_AIX (MODULES-2478) Make root_home fact work on AIX using native lsuser command
|
Thank you for your contribution! |
jfautley
deleted the
ticket/MODULES-2478-support_root_home_fact_on_AIX
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root_home fact returns nil on AIX due to the operating system not providing getent. The recommended replacement for this is the 'lsuser' command.
This PR adds a new fact, confined to kernel=>aix to use libuser to return root's configured home directory.