Ignore :undefined_variable "reason" in getvar

[mks-m]

catch returns value of second argument to throw, which until puppetlabs/puppet@860a276#diff-bb62983f077c2b43d065be52de182209R514 was nil, but now is non-falsey reason for error. short-circuit using return and eval to nil if throw was caught.

[DavidS]

I could reproduce this on the quick with puppet 4.7.0 only by modifying the puppet source code (see below). Still, the code is more robust with this change so in it goes!

diff --git a/lib/puppet/parser/scope.rb b/lib/puppet/parser/scope.rb
index 57294c1..a1fb5f0 100644
--- a/lib/puppet/parser/scope.rb
+++ b/lib/puppet/parser/scope.rb
@@ -506,7 +506,7 @@ class Puppet::Parser::Scope
       if next_scope
         next_scope.lookupvar(name, options)
       else
-        variable_not_found(name)
+        variable_not_found(name, "error")
       end
     end
   end

[mks-m]

@DavidS what tripped me was a mis-used variable name: getvar('$::some::var') which raised exception "class $ not found" which then leaked into result of getvar. thanks for merge.

[DavidS]

@keymone See DavidS@ba67577 . thanks for coming back!