Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-4098) Sync the rest of the files #712

Merged
merged 1 commit into from
Jan 24, 2017
Merged

(MODULES-4098) Sync the rest of the files #712

merged 1 commit into from
Jan 24, 2017

Conversation

hunner
Copy link
Contributor

@hunner hunner commented Jan 19, 2017

DavidS
DavidS previously requested changes Jan 19, 2017

and some parts:

Copyright (C) 2011 Krzysztof Wilczynski
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope.

@@ -20,4 +12,4 @@ Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
limitations under the License.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last newline missing.

@@ -0,0 +1 @@
# Appveyor is only enabled on modules that support windows
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a broken appveyor file will cause issues when trying to enable appveyor as the "Only run on branches with appveyor.yml" setting will not trigger.

PuppetLint.configuration.send('disable_documentation')
PuppetLint.configuration.send('disable_single_quote_string_with_variables')
PuppetLint.configuration.ignore_paths = ["spec/**/*.pp", "pkg/**/*.pp", "vendor/**/*.pp"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This overrides the better defaults from puppetlabs_spec_helper.

@eputnam eputnam merged commit db8c1fb into master Jan 24, 2017
@hunner hunner deleted the hunner_msync branch January 24, 2017 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants