Ensure resource attempt 2 #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 15, 2012 15:56
…esource"" This reverts commit 1e09833.
The ensure_resource function actually calls two other functions, create_resources and defined_with_param. When calling Puppet functions from Ruby, you sometimes have to load the functions manually if they have not been called before. This commit explicitly loads the functions that ensure_resource depends on from within the function.
|
I'm still getting order-dependent test failures with Puppet 2.6. I spent quite a bit of effort on this yesterday afternoon and @pcarlisle chipped in a bit at the end of the day. Do you have a need for these functions to work with Puppet 2.6 ? After sleeping on it last night I don't think it's worth the time and effort to continue maintaining backwards compatibility with 2.6. I'd like to merge this into master, release stdlib 3.0.0 from master and establish the 2.x branch for Puppet 2.6 compatible features. Thoughts? |
|
@jeffmccune I am ok with that. Thanks for all of the time you have spent trying to get this into stdlib.I really appreciate it. I may take a look at the order dependent issues what you ran into when I have a little more time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request reverts the previously reverted commit from the ensure_resource pull request.
It also adds code for explicit function loading for the functions that ensure_resource depends on (which should resolve the 2.6.x failures)