Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Maint) Fix mis-use of rvalue functions as statements #91

Merged
merged 2 commits into from
Aug 20, 2012
Merged

(Maint) Fix mis-use of rvalue functions as statements #91

merged 2 commits into from
Aug 20, 2012

Commits on Aug 20, 2012

  1. Add .rspec file to repo root 

    Without this patch we don't get an opinionated rspec behavior.  This
patch makes the behavior of `rake test` and `rspec spec/` opinionated
by including some default options.
    Jeff McCune committed Aug 20, 2012
    Configuration menu
    Copy the full SHA
    88789e8 View commit details
    Browse the repository at this point in the history

  2. (Maint) Fix mis-use of rvalue functions as statements 

    Without this patch applied the spec tests are invalid because they call
rvalue functions as if they were statements.  This is a problem because
Puppet 2.7.x currently throws an exception if a rvalue function is
invoked as if it were a statement function.  This exception from Puppet
is causing tests to fail.

This patch fixes the problem by changing the tests to assign the return
value of the functions to a variable.  This fixes the problem by
invoking the functions properly.

Paired-with: Andrew Parker <andy@puppetlabs.com>
    Jeff McCune committed Aug 20, 2012
    Configuration menu
    Copy the full SHA
    4492913 View commit details
    Browse the repository at this point in the history