Add proxy / environment support for tomcat::install

[edestecd]

We need to download tomcat through a corporate web proxy...

[edestecd]

Added Documentation for the new environment param...

[tphoney]

Hi @edestecd. The code looks solid. But i worry about whether or not this will be used by a majority of users of the module. This extra environment variables and setup doesn't feel right in the module itself. I had a look at other modules to see what they did. I was unable to see prior art of this.

I could however be massively wrong.

[edestecd]

What other options do we have to set a web proxy for the staging module to use when downloading?

[edestecd]

@tphoney Here is one example I can find:
https://github.com/stankevich/puppet-python/blob/master/manifests/pip.pp#L78

If you are using the archive module instead of staging, it has specific params for proxy, which I think are better. This would require a refactor of the tomcat module.
https://github.com/voxpupuli/puppet-php/blob/master/manifests/composer.pp#L30
https://github.com/puppetlabs/puppetlabs-java/blob/master/manifests/oracle.pp#L95

[DavidS]

@edestecd this is fine for now. Long-term someone needs to migrate tomcat off the staging module to puppet/archive, which has proxy support built in.

[edestecd]

Is there a Jira ticket for switching to archive?
I may take this on, or at least make a start of it.

[tphoney]

@edestecd thanks for the work on this. I will have a search and get back to you. Apologies if i was out of line earlier.

[tphoney]

@edestecd https://tickets.puppetlabs.com/browse/MODULES-4202

[edestecd]

@tphoney no worries. Constructive criticism always welcome ;) Using environment for proxy settings is kind of hacky...