#[puppethack] MODULES-4003 Fix ordering issue when using a package for installation #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 13, 2016 11:13
Added the rbenv .ruby-version file to gitignore
Add a 'require => Tomcat::Install[$name]' to the ensure_resource function at line 78
|
Fixed Title |
dhollinger
changed the title
dhollinger
changed the title
|
I think it would be better to add any dependencies needed to https://github.com/puppetlabs/puppetlabs-tomcat/blob/master/manifests/instance/dependencies.pp as the titles can change based on the various kinds of deployments. |
|
Though I guess in this case |
Removing logic that checks to see if catalina_base and catalina_home are the same. This is being done as the catalina_home directory is only created if its path doesn't match catalina_base. In that case, it creates an empty directory that is unused by the module anyway.
tphoney
pushed a commit
to tphoney/puppetlabs-tomcat
that referenced
this pull request
Dec 21, 2016
DavidS
added a commit
that referenced
this pull request
Dec 21, 2016
MODULES-4238 fix #184 create $catalina_home
ikogan
pushed a commit
to ohioit/puppetlabs-tomcat
that referenced
this pull request
Jan 10, 2017
ikogan
pushed a commit
to ohioit/puppetlabs-tomcat
that referenced
this pull request
Jan 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the initial change, working to add some more extensive testing to better validate the it.