Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix retval checks in init script template #221

Merged
merged 1 commit into from Jul 24, 2017
Merged

fix retval checks in init script template #221

merged 1 commit into from Jul 24, 2017

Conversation

fraenki
Copy link
Contributor

@fraenki fraenki commented Jul 6, 2017

The status command in the init script is not working:

# service tomcat-foobar status
CATALINA_BASE /opt/foobar
CATALINA_HOME /opt/foobar
CATALINA_LOCAL
CATALINA_OPTS 
JAVA_OPTS 
TOMCAT_USER tomcat
/etc/init.d/tomcat-foobar: 169: [: 0: unexpected operator
pidfile exists but tomcat dead

And thus the puppet run will fail, although the application was started (or is running) correctly:

Error: Could not start Service[tomcat-foobar]: Execution of 'service tomcat-foobar start' returned 1: CATALINA_BASE /opt/foobar
CATALINA_HOME /opt/foobar
CATALINA_LOCAL
CATALINA_OPTS 
JAVA_OPTS 
TOMCAT_USER tomcat

This PR fixes the small syntax issues in the init script template.

@hunner hunner merged commit 3eb4c8d into puppetlabs:master Jul 24, 2017
hunner added a commit that referenced this pull request Jul 24, 2017
fix retval checks in init script template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants