Refactor valve types

[h-haaks]

No description provided.

[puppet-community-rangefinder]

tomcat::config::context::valve is a type

Breaking changes to this file MAY impact these 1 modules (near match):

• autostructure-docker_tomcat_module

tomcat::config::server::valve is a type

Breaking changes to this file WILL impact these 2 modules (exact match):

• fervid-secure_tomcat_cis
• autostructure-secure_tomcat

Breaking changes to this file MAY impact these 1 modules (near match):

• autostructure-docker_tomcat_module

This module is declared in 8 of 575 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[h-haaks]

@david22swan
My second attempt to resolve MODULES-10855.
I hope you have some time to look at it.

[david22swan]

@h-haaks
Sorry for the wait on the review, missed the notification from Github.
Anyway overall this look's good to me and it all runs successfully against the release pipeline so I'm gonna approve it.
However due to its backwards incompatible nature I want an approve from another member of the team in order to merge it.

[carabasdaniel]

👍 Thank you for your contribution @h-haaks

[h-haaks]

Thanks @david22swan and @carabasdaniel
Could any of you please tell me if I'm supposed to close https://tickets.puppetlabs.com/browse/MODULES-10855 my self, or if it should be looked at by someone before closing.

[h-haaks]

By the way @david22swan, why did you label this backwards-incompatible?
I don't think it is, because as my test show it's still ok to use the resource_name and resource_type params of tomcat::config::context::valve.
You'll just get a warning that tells you that it is deprecated.

[david22swan]

@h-haaks
Yeah had labelled this wrong sorry.
Have changed it to feature and will close the ticket in a minute.
Thank's again for putting in the work.