MODULES-1478: Add a $purge_connectors parameter. #56
Conversation
| } | ||
|
|
||
| if $purge_connectors and ($connector_ensure =~ /^(absent|false)$/) { | ||
| fail('$connector_ensure must be set to \'true\' or \'present\' to use $purge_connections') |
There was a problem hiding this comment.
This should be $purge_connectors not $purge_connections
|
@philipwigg other than the one fail message comment, so many 👍s for this. so many. |
|
I've fixed the fail message and added a test for it. Thanks for reviewing my PR! |
| @@ -228,6 +228,10 @@ Sets the group to run Tomcat as. | |||
|
|
|||
| Specifies whether or not to install from source. A Boolean that defaults to 'true'. | |||
|
|
|||
| #####`$purge_connectors` | |||
|
|
|||
| Specifies whether or not to purge existing Connector elements from server.xml. For example, if hyou define an AJP connector using tomcat::instance::connector, then existing AJP connectors will be purged beforehand if $purge_connections is set to 'true'. Otherwise by default a new AJP connector element would be created which might not be what you expect. This makes defining connectors work in a declaritve way. A Boolean that defaults to 'false'. | |||
There was a problem hiding this comment.
The second sentence is a little confusing, maybe reword to:
For example, if you define an AJP connector using tomcat::instance::connector and $purge_connectors is set to true, existing AJP connectors will be removed.
There was a problem hiding this comment.
declarative is misspelled.
|
@philipwigg ok, just found a couple of other cleanup things in the README. Once you've fixed those could you please rebase and squash to a single commit? Thanks! |
philipwigg
force-pushed
the
purge-connectors
branch
from
86f283a
to
ad3bf5c
Compare
|
@mhaskel I rewrote the README a bit more, rebased and squashed. Thanks for your input! |
MODULES-1478: Add a $purge_connectors parameter.
|
Thanks for the contribution @philipwigg |
See MODULES-1478.
Basically the way that this module adds additional Connector elements seems very un-Puppet-like.
This PR adds a parameter called $purge_connectors which removes all existing connectors for a given protocol so that if you define a single HTTP connector on port 8140 then that's the only HTTP connector you will have after the module has been applied. I think this is what most users will expect and want.
I've set it to false by default so that it's not a breaking change.