Added Manifest for Listener #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Manifest and Tests for Listener Element in server.xml. Updated the README and added an example for Tomcat 7 Instance with JMX Listener.
| define tomcat::config::server::listener ( | ||
| $catalina_base = $::tomcat::catalina_home, | ||
| $listener_ensure = 'present', | ||
| $class_name = undef, |
Added Parameter parent_server_port to select the server element.
|
@juame I'm working on a PR(to your PR) to add the ability to nest the Listener under Server, Host, or Engine elements, should have it up shortly. |
|
If https://github.com/juame/puppetlabs-tomcat/pull/1 looks good to you and you merge it I should be able to merge this one! Thanks for your work on this @juame! |
Allow Listener to be nested below Server, Engine, or Host elements
underscorgan
pushed a commit
that referenced
this pull request
Nov 18, 2014
Added Manifest for Listener
|
Thanks for the contribution @juame |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Manifest and Tests for Listener Element in server.xml. Updated the README and added an example for Tomcat 7 Instance with JMX Listener.