Adds parameter for enabling Tomcat service on boot #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -42,6 +47,10 @@ | |||
| fail('$service_name must be specified when $use_init is set to true') | |||
| } | |||
|
|
|||
| if $service_enable != undef and ! $use_init { | |||
| fail('$use_init must be set to true when $service_enable is set') | |||
There was a problem hiding this comment.
This should just be a warning, not a fail.
There was a problem hiding this comment.
Hm. What would happen if we allowed service to be enabled when there is not init script?
bmjen
force-pushed
the
add-enable-attr-to-service
branch
from
02f39c0
to
bda8b74
Compare
underscorgan
pushed a commit
that referenced
this pull request
Mar 17, 2015
Adds parameter for enabling Tomcat service on boot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new feature requested in:
https://tickets.puppetlabs.com/browse/MODULES-1682