Validate that catalina_base does not to end with / #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately Augeas does not work if path contains double slash, it simply does not find the file and fails silently to update it. I've added the validate_re to save others some time.
| @@ -33,7 +33,8 @@ | |||
| validate_re($connector_ensure, '^(present|absent|true|false)$') | |||
| validate_hash($additional_attributes) | |||
| validate_bool($purge_connectors) | |||
|
|
|||
| validate_re($catalina_base, '^.*[^/]$') | |||
There was a problem hiding this comment.
actually, i think it would be nice to add an error message here.
There was a problem hiding this comment.
yeah like for all other validate rules :)
There was a problem hiding this comment.
this is a special case, imo, and the reason why i created #102.
|
Closed in #102 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately Augeas does not work if path contains double slash, it simply
does not find the file and fails silently to update it.
I've added the validate_re to save others some time.