Merge pull request #365 from willmeek/modulesync_rubocop

Modulesync rubocop

.gitignore

@@ -1,24 +1,23 @@
-#This file is generated by ModuleSync, do not edit.
-pkg/
-Gemfile.lock
-Gemfile.local
-vendor/
-spec/fixtures/manifests/
-spec/fixtures/modules/
-log/
-junit/
-.vagrant/
+#This file is generated by ModuleSync, do not edit.Z
+*.iml
+.*.sw[op]
+.DS_Store
 .bundle/
-coverage/
-log/
 .idea/
 .metadata
-*.iml
-.*.sw[op]
+.vagrant/
 .yardoc
 .yardwarns
-.DS_Store
+Gemfile.local
+Gemfile.lock
+bin/
+coverage/
+doc/
+junit/
+log/
+pkg/
+spec/fixtures/manifests/
+spec/fixtures/modules/
 tmp/
 vendor/
-doc/
 

.rubocop.yml

@@ -95,4 +95,4 @@ Style/AsciiComments:
 Style/IfUnlessModifier:
   Enabled: false
 Style/SymbolProc:
-  Enabled: false
+  Enabled: false

Gemfile

@@ -28,10 +28,19 @@ def location_for(place_or_version, fake_version = nil)
 end
 
 # Used for gem conditionals
-supports_windows = false
 ruby_version_segments = Gem::Version.new(RUBY_VERSION.dup).segments
 minor_version = "#{ruby_version_segments[0]}.#{ruby_version_segments[1]}"
 
+# The following gems are not included by default as they require DevKit on Windows.
+# You should probably include them in a Gemfile.local or a ~/.gemfile
+#gem 'pry' #this may already be included in the gemfile
+#gem 'pry-stack_explorer', :require => false
+#if RUBY_VERSION =~ /^2/
+#  gem 'pry-byebug'
+#else
+#  gem 'pry-debugger'
+#end
+
 group :development do
   gem "puppet-module-posix-default-r#{minor_version}",    :require => false, :platforms => "ruby"
   gem "puppet-module-win-default-r#{minor_version}",      :require => false, :platforms => ["mswin", "mingw", "x64_mingw"]
@@ -62,7 +71,6 @@ gem 'puppet', *location_for(ENV['PUPPET_GEM_VERSION'])
 gem 'facter', *location_for(ENV['FACTER_GEM_VERSION']) if ENV['FACTER_GEM_VERSION']
 gem 'hiera', *location_for(ENV['HIERA_GEM_VERSION']) if ENV['HIERA_GEM_VERSION']
 
-
 # Evaluate Gemfile.local if it exists
 if File.exists? "#{__FILE__}.local"
   eval(File.read("#{__FILE__}.local"), binding)

lib/puppet/provider/vcsrepo/git.rb

@@ -29,7 +29,7 @@ def create
       if @resource.value(:revision)
         checkout
       end
-      if !ensure_bare_or_mirror? && @resource.value(:submodules) == :true # rubocop:disable Lint/BooleanSymbol : Test's break if Boolean symbol is removed
+      if !ensure_bare_or_mirror? && @resource.value(:submodules) == :true
         update_submodules
       end
 
@@ -92,7 +92,7 @@ def revision=(desired)
       end
     end
     # TODO: Would this ever reach here if it is bare?
-    if !ensure_bare_or_mirror? && @resource.value(:submodules) == :true # rubocop:disable Lint/BooleanSymbol : Test's break if Boolean symbol is removed
+    if !ensure_bare_or_mirror? && @resource.value(:submodules) == :true
       update_submodules
     end
     update_owner_and_excludes
@@ -549,7 +549,7 @@ def git_version
 
   # @!visibility private
   def git_with_identity(*args)
-    if @resource.value(:trust_server_cert) == :true # rubocop:disable Lint/BooleanSymbol : Test's break if Boolean symbol is removed
+    if @resource.value(:trust_server_cert) == :true
       git_ver = git_version
       git_ver_err = "Can't set sslVerify to false, the -c parameter is not supported in Git #{git_ver}. Please install Git 1.7.2 or higher."
       return raise(git_ver_err) unless Gem::Version.new(git_ver) >= Gem::Version.new('1.7.2')

lib/puppet/provider/vcsrepo/svn.rb

@@ -83,7 +83,7 @@ def buildargs
       args.push('--config-dir', @resource.value(:configuration))
     end
 
-    if @resource.value(:trust_server_cert) != :false # rubocop:disable Lint/BooleanSymbol
+    if @resource.value(:trust_server_cert) != :false
       args.push('--trust-server-cert')
     end
 

lib/puppet/type/vcsrepo.rb

@@ -286,7 +286,7 @@ def insync?(is)
   newparam :trust_server_cert do
     desc 'Trust server certificate'
     newvalues(true, false)
-    defaultto :false # rubocop:disable Lint/BooleanSymbol
+    defaultto :false
   end
 
   autorequire(:package) do