Fix :false to be default value

false is not a valid value; only :false is.

Gemfile

@@ -16,6 +16,7 @@ group :development, :unit_tests do
   gem 'simplecov',               :require => false
   gem 'puppet_facts',            :require => false
   gem 'json',                    :require => false
+  gem 'pry',                     :require => false
 end
 
 group :system_tests do

lib/puppet/provider/vcsrepo/svn.rb

@@ -63,7 +63,7 @@ def buildargs
       args.push('--config-dir', @resource.value(:configuration))
     end
 
-    if @resource.value(:trust_server_cert)
+    if @resource.value(:trust_server_cert) != :false
       args.push('--trust-server-cert')
     end
 

lib/puppet/type/vcsrepo.rb

@@ -231,7 +231,7 @@ def retrieve
   newparam :trust_server_cert do
     desc "Trust server certificate"
     newvalues(:true, :false)
-    defaultto false
+    defaultto :false
   end
 
   autorequire(:package) do

spec/unit/puppet/provider/vcsrepo/svn_spec.rb

@@ -65,9 +65,17 @@
     end
 
     context "with trust_server_cert" do
+      it "should execute 'svn checkout' without a trust-server-cert" do
+        resource[:source] = 'exists'
+        resource[:trust_server_cert] = :false
+        provider.expects(:svn).with('--non-interactive', 'checkout',
+          resource.value(:source),
+          resource.value(:path))
+        provider.create
+      end
       it "should execute 'svn checkout' with a trust-server-cert" do
         resource[:source] = 'exists'
-        resource[:trust_server_cert] = true
+        resource[:trust_server_cert] = :true
         provider.expects(:svn).with('--non-interactive', '--trust-server-cert', 'checkout',
           resource.value(:source),
           resource.value(:path))