Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVN provider should check for '^Revision:' and not '^Last Changed Rev:' #43

Closed
razorsedge opened this issue Nov 26, 2012 · 3 comments
Closed

Comments

@razorsedge
Copy link

This subversion repository revision:

[root@host somedir]# svn info
Path: .
URL: http://svn/someapp/trunk
Repository Root: http://svn/someapp
Repository UUID: 3086d4a2-aef2-4587-acb0-e7a012cffd39
Revision: 480863
Node Kind: directory
Schedule: normal
Last Changed Author: root
Last Changed Rev: 480862
Last Changed Date: 2012-11-12 12:35:48 -0600 (Mon, 12 Nov 2012)

causes this Vcsrepo code to constantly update (over and over)

vcsrepo { '/some/dir':
  ensure              => 'present',
  provider            => 'svn',
  source              => 'http://svn/someapp/trunk',
  revision            => '480863',
}

Mon Nov 26 10:37:49 -0700 2012 /Vcsrepo[/some/dir]/revision (notice): revision changed '480862' to '480863'

The code in lib/puppet/provider/vcsrepo/svn.rb should be changed from svn(*args)[/^Last Changed Rev:\s+(\d+)/m, 1] to svn(*args)[/^Revision:\s+(\d+)/m, 1].

@nightlyone
Copy link

Just tested it, fixed it in our fork at github.com/Jimdo/puppetlabs-vcsrepo and it really makes checking out the latest version work flawlessly.

@sodabrew
Copy link

Please submit a PR and I'll merge it. Does this also work for branches / tags revision types?

sodabrew pushed a commit that referenced this issue Aug 13, 2013
SVN provider should check for '^Revision:' and not '^Last Changed
Rev:'.  Addresses GitHub Issue #43.
@sodabrew
Copy link

Thank you @razorsedge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants