(FACT-1346) Add default Windows facts as a custom fact #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note I didn't add tests for the fact as the code is too simple, and there's no testing on a real Windows platform so mocking is of limited value. |
|
The fact list comes from the conversation in https://tickets.puppetlabs.com/browse/FACT-1346 |
Previously facter doesn't expose default Windows environment variables such as windir or APPDATA. This commit adds a custom structured fact which exposes a whitelisted set of windows environment variables which can be easily consumed in manifests. Note that the environment name is purposely uppercased as Windows env. vars are not case sensitive and it makes it easier to author Puppet manifests if we're not constantly checking; is TMP or tmp or Tmp. The custom facts can be accessed via the $facts hash e.g. $appdata = $facts['windows_env']['APPDATA'].
glennsarti
force-pushed
the
fact-1346-add-windows-env-fact
branch
from
a9380de
to
aa78966
Compare
TraGicCode
reviewed
Oct 3, 2018
TraGicCode
approved these changes
Oct 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously facter doesn't expose default Windows environment variables such as
windir or APPDATA. This commit adds a custom structured fact which exposes a
whitelisted set of windows environment variables which can be easily consumed in
manifests. Note that the environment name is purposely uppercased as Windows
env. vars are not case sensitive and it makes it easier to author Puppet
manifests if we're not constantly checking; is TMP or tmp or Tmp.
The custom facts can be accessed via the $facts hash e.g.
$appdata = $facts['windows_env']['APPDATA'].