Fix: Could not set 'present' on ensure: uninitialized constant Win32::Registry::KEY_WOW64_64KEY

[cmchoi2000]

Removed Reg key check.

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

[RandomNoun7]

Context

PR fixes the following issue

Error: /Stage[main]/Surfscan::Test_env/Windows_env[Add somecode]/ensure: change from 'absent' to 'present' failed: Could not set 'present' on ensure: uninitialized constant Win32::Registry::KEY_WOW64_64KEY
Did you mean?  KEY_WOW64_64KEY (file: /etc/puppetlabs/code/environments/production/site/<snip>/manifests/test_env.pp, line: 2)

In some environments the top scope KEY_WOW64_64KEY variable is already defined in another scope, but the module only ever references the namespaced Win32::Registry::KEY_WOW64_64KEY constant, which is now not defined.

The Puppetlabs registry module already ran into this bug a while back and used this same strategy to fix it.

[RandomNoun7]

Approved on the basis of:

1. The fix was manually tested at the customer site and fixed the issue with no discernable side effects
2. This same fix was implemented in the puppetlabs-registry module back in January 2017 without issue.

[bastelfreak]

Hi @cmchoi2000, thanks for the PR! The change itself looks good, but can you please update the pull request title to briefly describe what/why it got changed? Afterwards we can merge it and do a new release.

[cmchoi2000]

Do I need to resubmit the pull again with anew title? From: Tim Meusel <notifications@github.com> Sent: Monday, June 22, 2020 11:09 AM To: voxpupuli/puppet-windows_env <puppet-windows_env@noreply.github.com> Cc: Choi, Charles <Charles.Choi@kla-tencor.com>; Mention <mention@noreply.github.com> Subject: [EXTERNAL]: Re: [voxpupuli/puppet-windows_env] Update windows_env.rb. (#70) Hi @cmchoi2000<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_cmchoi2000&d=DwMCaQ&c=YlQJHsR4e2z6sq5iNUb1-8UzPbEw9OnHGjBjyVyvpyA&r=VUv3gfJEBfm_SAlWE_VOJT-JuHOCCyRCfSyKvokGnho&m=DXtMOyrxvSeVBaQEvtnlL-VdHloJAq8cEPlVOjFOQQM&s=mucOpCfLl648MP9G__aLF8BqMuBIFd67vHPukcRINdY&e=>, thanks for the PR! The change itself looks good, but can you please update the pull request title to briefly describe what/why it got changed? Afterwards we can merge it and do a new release. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_voxpupuli_puppet-2Dwindows-5Fenv_pull_70-23issuecomment-2D647689469&d=DwMCaQ&c=YlQJHsR4e2z6sq5iNUb1-8UzPbEw9OnHGjBjyVyvpyA&r=VUv3gfJEBfm_SAlWE_VOJT-JuHOCCyRCfSyKvokGnho&m=DXtMOyrxvSeVBaQEvtnlL-VdHloJAq8cEPlVOjFOQQM&s=_KfCT4k4nIZFP5m4rTCoA8IyKbrOQNNGtkKfQcCht4Y&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AINYUZP225EI6M4LB2YSNWLRX6M5TANCNFSM4N7GOJZA&d=DwMCaQ&c=YlQJHsR4e2z6sq5iNUb1-8UzPbEw9OnHGjBjyVyvpyA&r=VUv3gfJEBfm_SAlWE_VOJT-JuHOCCyRCfSyKvokGnho&m=DXtMOyrxvSeVBaQEvtnlL-VdHloJAq8cEPlVOjFOQQM&s=VGS1qxlOKnzHIndJcgh30dpHIMj078qf9U5vp4TBvkY&e=>.

[RandomNoun7]

@cmchoi2000 No, you don't need to resubmit. You can open the PR web page and click on the title. When you click on the title it will turn into a text box you can edit directly.

[cmchoi2000]

I don’t know how to goto PR web page. From: Bill Hurt <notifications@github.com> Sent: Monday, June 22, 2020 11:21 AM To: voxpupuli/puppet-windows_env <puppet-windows_env@noreply.github.com> Cc: Choi, Charles <Charles.Choi@kla-tencor.com>; Mention <mention@noreply.github.com> Subject: [EXTERNAL]: Re: [voxpupuli/puppet-windows_env] Update windows_env.rb. (#70) @cmchoi2000<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_cmchoi2000&d=DwMCaQ&c=YlQJHsR4e2z6sq5iNUb1-8UzPbEw9OnHGjBjyVyvpyA&r=VUv3gfJEBfm_SAlWE_VOJT-JuHOCCyRCfSyKvokGnho&m=LXMm17jBSYJYEZKGifj3ChAJNt8PQjDQOC1HdjbkT80&s=da_7c09Wmyi6iE1Jb7MIbVTA2W-0ZXyZyp5JkQXDkM4&e=> No, you don't need to resubmit. You can open the PR web page and click on the title. When you click on the title it will turn into a text box you can edit directly. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_voxpupuli_puppet-2Dwindows-5Fenv_pull_70-23issuecomment-2D647695031&d=DwMCaQ&c=YlQJHsR4e2z6sq5iNUb1-8UzPbEw9OnHGjBjyVyvpyA&r=VUv3gfJEBfm_SAlWE_VOJT-JuHOCCyRCfSyKvokGnho&m=LXMm17jBSYJYEZKGifj3ChAJNt8PQjDQOC1HdjbkT80&s=3XatWsAuOYtjk5eXiIe7z0-Tf20qnzGqx8f4NKwDfd4&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AINYUZJPZBICYYDIT33TJTTRX6OKHANCNFSM4N7GOJZA&d=DwMCaQ&c=YlQJHsR4e2z6sq5iNUb1-8UzPbEw9OnHGjBjyVyvpyA&r=VUv3gfJEBfm_SAlWE_VOJT-JuHOCCyRCfSyKvokGnho&m=LXMm17jBSYJYEZKGifj3ChAJNt8PQjDQOC1HdjbkT80&s=7pM8DgUmDw95KvcTcpkOGGCgmVBizM5ULCALf8vO8Hw&e=>.

[RandomNoun7]

@cmchoi2000 At the bottom of the emails you are recieving is a link that says view it on GitHub. Click that link and it will take you directly to the Pull Request page where you can click on the title and edit it.

[cmchoi2000]

I changed it to “Fix: Could not set 'present' on ensure: uninitialized constant Win32::Registry::KEY_WOW64_64KEY”. Is this sufficient? From: Bill Hurt <notifications@github.com> Sent: Monday, June 22, 2020 11:28 AM To: voxpupuli/puppet-windows_env <puppet-windows_env@noreply.github.com> Cc: Choi, Charles <Charles.Choi@kla-tencor.com>; Mention <mention@noreply.github.com> Subject: [EXTERNAL]: Re: [voxpupuli/puppet-windows_env] Update windows_env.rb. (#70) @cmchoi2000<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_cmchoi2000&d=DwMCaQ&c=YlQJHsR4e2z6sq5iNUb1-8UzPbEw9OnHGjBjyVyvpyA&r=VUv3gfJEBfm_SAlWE_VOJT-JuHOCCyRCfSyKvokGnho&m=6Yp53hn4GZ5oVUf2gEf6VhaNUvqHRviY23yznzfHGyc&s=G5qJARwRrP3YcZud3awJYkEdXYtYTH9ra9MyIk3iN2A&e=> At the bottom of the emails you are recieving is a link that says view it on GitHub. Click that link and it will take you directly to the Pull Request page where you can click on the title and edit it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_voxpupuli_puppet-2Dwindows-5Fenv_pull_70-23issuecomment-2D647698163&d=DwMCaQ&c=YlQJHsR4e2z6sq5iNUb1-8UzPbEw9OnHGjBjyVyvpyA&r=VUv3gfJEBfm_SAlWE_VOJT-JuHOCCyRCfSyKvokGnho&m=6Yp53hn4GZ5oVUf2gEf6VhaNUvqHRviY23yznzfHGyc&s=M03C_59g_FQGpyvEVWFafCLpR-8R62GXG0YCQEPHLXA&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AINYUZMJQWAQXT5VCTJU433RX6PDFANCNFSM4N7GOJZA&d=DwMCaQ&c=YlQJHsR4e2z6sq5iNUb1-8UzPbEw9OnHGjBjyVyvpyA&r=VUv3gfJEBfm_SAlWE_VOJT-JuHOCCyRCfSyKvokGnho&m=6Yp53hn4GZ5oVUf2gEf6VhaNUvqHRviY23yznzfHGyc&s=3HGhY-WuVtJgRaIUJY4g-Nl307aO0emEirQFMOgqA5I&e=>.