(MODULES-3475) Support AlwaysAutoRebootAtScheduledTimeMinutes #48
Conversation
|
How is this different than #47? |
|
And now I'm seeing it in the JIRA ticket... |
|
Yap, that's different. ;) |
| let(:reg_key) { "#{au_key}\\AlwaysAutoRebootAtScheduledTimeMinutes" } | ||
| let(:param_sym) { :always_auto_reboot_at_scheduled_time_minutes } | ||
| let(:below_range) { 14 } | ||
| let(:above_range) { 181 } |
There was a problem hiding this comment.
14 is the first error below range, 181 is the first value above range.
It looks like you set the tests up correctly. I'm not sure what would have caused the failure straight away.
|
@adasko I'll look at the test failures and see if I can help. In the mean time could you please adjust your commit messages to conform to the contributing guidelines? |
adasko
changed the title
The AlwaysAutoRebootAtScheduledTimeMinutes key allows the user to set the time after which computer will automaticaly restart after applying the updates regardless if a user is logged on or not instead of waiting next one days before restart
|
OK, I've changed the commit message a bit. Hope it looks better now. |
|
@adasko Looks like Travis CI and Appveyor found some test failures |
|
@glennsarti yes, that is true. Some of my code failed the test. The output of the failed test looks like this:
Seems that test expects the beginning of the range to be one digit value. In this case that's the wrong approach, since the right range for this parameter is:
Please check the comments above. |
|
@adasko So that other PR is merged, I've restarted your CI jobs. Hopefully it's all green |
https://tickets.puppetlabs.com/browse/MODULES-3475
adding support for AlwaysAutoRebootAtScheduledTimeMinutes which allows to restart host immediately after installing the updates