(MODULES-2420) omit ensure => running due to "trigger start" #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In newer Windows versions wsuaserv supports a start type of "manual (trigger start)" which is another form of running/enabled in which the service will start (on-demand) in response to some defined event. However, in the wsus-client module, puppet sees this state as enabled but not running, and starts the service with every run. The short-term fix in this commit is to consider the service running when enabled on these operating systems. The long-term fix, captured by PUP-6489 may be to modify the puppet windows service provider to support the trigger state. It's unclear at this time whether that effort would be justified because at this time it seems like trigger start services are not commonplace and aren't an officially supported service type. reference http://mikefrobbins.com/2015/12/24/use-powershell-to-determine-services-with-a-starttype-of-automatic-or-manual-with-trigger-start/ Signed-off-by: Moses Mendoza <mendoza.moses@gmail.com>
|
this PR is intended to supersede #50 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In newer Windows versions wsuaserv supports a start type of "manual (trigger
start)" which is another form of running/enabled in which the service will
start (on-demand) in response to some defined event. However, in the
wsus-client module, puppet sees this state as enabled but not running, and
starts the service with every run. The short-term fix in this commit is to
consider the service running when enabled on these operating systems. The
long-term fix, captured by PUP-6489 may be to modify the puppet windows service
provider to support the trigger state. It's unclear at this time whether that
effort would be justified because at this time it seems like trigger start
services are not commonplace and aren't an officially supported service type.
reference
http://mikefrobbins.com/2015/12/24/use-powershell-to-determine-services-with-a-starttype-of-automatic-or-manual-with-trigger-start/
Signed-off-by: Moses Mendoza mendoza.moses@gmail.com