Added 'env' and 'passenv' service parameters #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from man xinetd.conf:
env The value of this attribute is a list of strings of the form ’name=value’. These strings will be added to the environment before starting a server (therefore the server’s envi-
ronment will include xinetd’s environment plus the specified strings).
passenv The value of this attribute is a list of environment variables from xinetd’s environment that will be passed to the server. An empty list implies passing no variables to the
server except for those explicitly defined using the env attribute. (notice that you can use this attribute in conjunction with the env attribute to specify exactly what envi-
ronment will be passed to the server).
from man xinetd.conf:
env The value of this attribute is a list of strings of the form ’name=value’. These strings will be added to the environment before starting a server (therefore the server’s envi-
ronment will include xinetd’s environment plus the specified strings).
passenv The value of this attribute is a list of environment variables from xinetd’s environment that will be passed to the server. An empty list implies passing no variables to the
server except for those explicitly defined using the env attribute. (notice that you can use this attribute in conjunction with the env attribute to specify exactly what envi-
ronment will be passed to the server).
|
Could you add some tests and documentation for the new parameters? Also, you'll need to rebase. Thanks! |
Conflicts: manifests/service.pp
|
@vchepkov ping? |
|
I afraid I don't really know how to write tests, sorry. I know the code works though, I have been using it from my fork for almost a year now. |
underscorgan
pushed a commit
to underscorgan/puppetlabs-xinetd
that referenced
this pull request
Apr 6, 2015
underscorgan
pushed a commit
to underscorgan/puppetlabs-xinetd
that referenced
this pull request
Apr 6, 2015
underscorgan
pushed a commit
to underscorgan/puppetlabs-xinetd
that referenced
this pull request
Apr 6, 2015
underscorgan
pushed a commit
to underscorgan/puppetlabs-xinetd
that referenced
this pull request
Apr 6, 2015
underscorgan
pushed a commit
to underscorgan/puppetlabs-xinetd
that referenced
this pull request
Apr 6, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These parameters are required for such services as 'cvspserver'
From xinetd.conf manual: