Add the ability to manage the xinetd.d conf dir #47
Conversation
| @@ -19,6 +19,7 @@ | |||
| $service_status = $xinetd::params::service_status, | |||
| $service_hasrestart = $xinetd::params::service_hasrestart, | |||
| $service_hasstatus = $xinetd::params::service_hasstatus, | |||
| $manage_confdir = false, | |||
There was a problem hiding this comment.
Could you rename this to purge_confdir? Because even if this is false, it is still being managed.
If enabled, then the xinet.d confdir will be purged of any unmanaged files.
claytono
force-pushed
the
manage_confdir
branch
from
dcd8e89
to
57c37d7
Compare
|
Rebased and updated the parameter name. |
| mode => '0755', | ||
| ensure => directory, | ||
| mode => '0755', | ||
| recurse => $purge_confdir, |
There was a problem hiding this comment.
I'm not liking the ability for recurse => true here. Would it still work for you if only purge was set?
There was a problem hiding this comment.
It's there only because the Type Reference specifically says that purge => true only really makes sense with recurse => true. I didn't really think about it past that. What is the concern?
There was a problem hiding this comment.
Yeah, purge => true only works with recurse => true. Perhaps you were thinking of a file resource with a source of a remote directory and recurse => true being slow?
There was a problem hiding this comment.
ahhh, yeah, that's it. Apologies on the confusion!
Add the ability to manage the xinetd.d conf dir
If enabled, then the xinet.d confdir will be purged of any unmanaged
files.