Puppetv4 #69
Puppetv4 #69
Conversation
ghoneycutt
force-pushed
the
puppetv4
branch
4 times, most recently
from
84932c9
to
4dce701
Compare
| PuppetLint.configuration.relative = true | ||
| PuppetLint.configuration.ignore_paths = ["spec/**/*.pp", "pkg/**/*.pp"] | ||
|
|
||
| desc 'Validate manifests, templates, and ruby files' |
There was a problem hiding this comment.
There's a validate task in puppetlabs_spec_helper. Why not use that?
|
@ekohl I removed that bit from the Rakefile and rebased. Ready for merge? |
|
👍 on green tests. |
|
@DavidS Could you please review this PR? |
| @@ -23,4 +23,9 @@ else | |||
| gem 'puppet', :require => false | |||
| end | |||
|
|
|||
| # rspec must be v2 for ruby 1.8.7 | |||
| if RUBY_VERSION >= '1.8.7' and RUBY_VERSION < '1.9' | |||
| gem 'rspec', '~> 2.0' | |||
There was a problem hiding this comment.
rspec 3.1 is the last rspec that works on ruby 1.8.7:
https://github.com/puppetlabs/puppetlabs-stdlib/blob/master/Gemfile#L15
There was a problem hiding this comment.
I do like the basic formulation.
|
Please squash the two commits pertaining to the nice parameter. |
|
Oh wow, this module does still use the serverspec things :-/ |
|
So changing rspec from |
Without this commit the range for nice is -19 to 19 which is incorrect. nice(1) states that the valid values range from -20 to 19.
|
That might of worked with stdlib though that module is fundamentally different |
Add puppet 4 testing and document/test/fix the "nice" parameter
|
Thank you for your contribution! |
|
@DavidS thanks for the review |
No description provided.