Update to newest modulesync_configs [3610af2] #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
@DavidS So you dropped support for Ruby 1.8.7 ? |
|
I dropped testing for ruby 1.8.7. It's not like there is much going on with this module anyways. |
|
When you stop testing for a platform, it signals that the platform is no longer supported. I read this as we only test against the newest versions of Puppet (with future parser) using Ruby 2.1.x. This is disconcerting because many of us are not using that combination. I bring this up here, though the change seemed to be triggered by module-sync, so I guess this is happening for many modules. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.