Allow service definition without explicit group #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis CI failure seems to be caused by gem requirement Ruby version >= 2.0. |
The group setting may be omitted in a service configuration to use the users primary group. This config is currently not possible because setting the group parameter to 'undef' will use the os specific default group instead. This patch adds an additional parameter 'use_default_group' to control this behaviour. Using the default 'true' keeps the old behaviour. Setting the parameter to 'false' and leaving the group unset will omit the group setting from the service config file.
|
Tests are successful after modulesync update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The group setting may be omitted in a service configuration to use the users primary group. This config is currently not possible because setting the group parameter to
undefwill use the os specific default group instead. This patch adds an additional parameteruse_default_groupto control this behaviour. Using the defaulttruekeeps the old behaviour. Setting the parameter tofalseand leaving the group unset will omit the group setting from the service config file.