(Modules-7207) Add 'caches' support #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zpool is a typeBreaking changes to this file MAY impact these 2 modules (near match):This module is declared in 1 of 575 indexed public
|
kBite
force-pushed
the
MODULES-7207/add-caches-support
branch
from
e323eff
to
daf5ea5
Compare
|
force pushed all changes as single commit |
add 'cache' to zpool's spec tests fix test 'when there are two logs' using 'log' instead of 'spare'
kBite
force-pushed
the
MODULES-7207/add-caches-support
branch
from
daf5ea5
to
e41646f
Compare
GabrielNagy
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based upon #26 (which seems abandoned). I incorporated the feedback of @GabrielNagy ...
(MODULES-7207)to prateekn's original commitOther changes like adding 'cache' to Puppet strings were merged to prateekn's original commit, too.