Skip to content

Commit

Permalink
(maint) - remove deprecated codecov gem
Browse files Browse the repository at this point in the history
  • Loading branch information
jordanbreen28 committed Jan 16, 2024
1 parent dbc63ab commit 52345ff
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 12 deletions.
1 change: 0 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ end
group :development do
gem 'puppet', *location_for(ENV['PUPPET_GEM_VERSION'])

gem 'codecov'
gem 'simplecov'
gem 'simplecov-console'

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ You can enable it, set the following environment variable:s

``SIMPLECOV=yes``

Remember to add the simplecov-console and codecov gems to your `Gemfile`. If you run `spec:simplecov` on Travis-CI or any of the other supported CI services, reports gets automatically uploaded to https://codecov.io/ .
Remember to add the simplecov-console gem to your `Gemfile`. If you run `spec:simplecov` on Travis-CI or any of the other supported CI services, reports get generated which can then be uploading to codecov.io with the supported codecov [uploader](https://docs.codecov.com/docs/codecov-uploader).

Some Notes for Windows Users
============================
Expand Down
7 changes: 3 additions & 4 deletions lib/puppetlabs_spec_helper/module_spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,12 @@ def verify_contents(subject, title, expected_lines)
begin
require 'simplecov'
require 'simplecov-console'
require 'codecov'

SimpleCov.formatters = [
SimpleCov::Formatter::HTMLFormatter,
SimpleCov::Formatter::Console,
SimpleCov::Formatter::Codecov
SimpleCov::Formatter::Console
]

SimpleCov.start do
track_files 'lib/**/*.rb'
add_filter '/spec'
Expand All @@ -48,7 +47,7 @@ def verify_contents(subject, title, expected_lines)
end
end
rescue LoadError
raise 'Add the simplecov, simplecov-console, codecov gems to Gemfile to enable this task'
raise 'Add the simplecov and simplecov-console gems to Gemfile to enable this task'
end
end

Expand Down
7 changes: 1 addition & 6 deletions spec/spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,6 @@
SimpleCov::Formatter::Console
]

if ENV['CI'] == 'true'
require 'codecov'
SimpleCov.formatters << SimpleCov::Formatter::Codecov
end

SimpleCov.start do
track_files 'lib/**/*.rb'

Expand All @@ -27,7 +22,7 @@
add_filter '/.vendor'
end
rescue LoadError
raise 'Add the simplecov, simplecov-console, codecov gems to Gemfile to enable this task'
raise 'Add the simplecov and simplecov-console gems to Gemfile to enable this task'
end
end

Expand Down

0 comments on commit 52345ff

Please sign in to comment.