puppet-syntax: Ensure we are using 4.1.1 or newer #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4.1.0 had a bug in the Hiera syntax validation. This is fixed in 4.1.1. See voxpupuli/puppet-syntax#171 for details.
|
This project has a |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #445 +/- ##
=======================================
Coverage 41.88% 41.88%
=======================================
Files 10 10
Lines 678 678
=======================================
Hits 284 284
Misses 394 394 ☔ View full report in Codecov by Sentry. |
jordanbreen28
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Thanks for this @bastelfreak!
RE the labels, we have bug for bug reports through issues and bugfix for prs. In the context of our changelog generator i believe bug & bugfix are inter-changeable, so doesn't matter much which one you use in the grand scheme of things. I'll update to bugfix for consistency sake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4.1.0 had a bug in the Hiera syntax validation. This is fixed in 4.1.1. See voxpupuli/puppet-syntax#171 for details.
Summary
Provide a detailed description of all the changes present in this pull request.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist