Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Add MAINTAINERS file #1214

Merged
merged 4 commits into from Sep 13, 2016
Merged

(maint) Add MAINTAINERS file #1214

merged 4 commits into from Sep 13, 2016

Conversation

kylog
Copy link

@kylog kylog commented Sep 8, 2016

Hi @KevinCorcoran @cprice404 @camlow325 @rlinehan @justinstoller @haus @jpinsonault:

Anticipating some possible questions:

  • This PR add a MAINTAINERS file to document who is maintaining this repo. The list of people started with the top 10 PR mergers in the last year, plus a little conversation here https://github.com/puppetlabs/kylo_scratchpad/pull/1/files#r76404602
  • If the list seems wrong, let's feel free to edit it.
  • The format of the file is documented here: http://github.com/puppetlabs/maintainers
  • And I used https://rubygems.org/gems/maintainers to construct the file
  • I pushed the PR branch to the puppetlabs space (rather than mine) so that all parties can edit collaboratively as needed
  • Note that this is a public repo. The email and name fields are optional here. As a starting point, I pre-populated them with the publicly available names/emails available for all of us on github (but took bogus or non-puppet emails as an indication that you may not want to share your puppet.com email). Please feel free to edit your email and name fields for any reason.

@justinstoller
Copy link
Member

Thanks @kylog ! I've added my work email. 👍

This commit replaces the list of maintainers in the README.md with a
link to the new MAINTAINERS file.  Also includes a couple of cosmetic
updates to the README.md - spelling.
@camlow325
Copy link
Contributor

👍 I added one more commit to scrub the old list of maintainer names from the README since we'll have them in the MAINTAINERS file now.

@jpinsonault
Copy link
Contributor

Added my email

@cprice404
Copy link

🙈

@rlinehan
Copy link
Contributor

lgtm

@kylog
Copy link
Author

kylog commented Sep 13, 2016

Any more signoffs we want on this sucker before someone hits merge (or squash-and-merge)?

@haus
Copy link
Contributor

haus commented Sep 13, 2016

q-beautiful

@haus haus merged commit f83667e into master Sep 13, 2016
@cprice404 cprice404 deleted the add-maintainers branch October 14, 2016 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants