Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docker container] Add 2 missing directories to fix permissions for #2181

Closed
wants to merge 1 commit into from
Closed

Conversation

jay7x
Copy link

@jay7x jay7x commented Sep 23, 2019

Following directories are owned by puppet user in container. If UID/GID is changed, those directories permissions must be updated too.

Following directories are owned by `puppet` user in container. If UID/GID is changed, those directories permissions must be updated too.
@jay7x jay7x requested a review from a team as a code owner September 23, 2019 05:23
@Iristyle
Copy link
Contributor

Iristyle commented Sep 23, 2019

I think we probably want to do the same in https://github.com/puppetlabs/pe-puppetserver/blob/kearney/docker/pe-puppetserver/docker-entrypoint.d/30-set-permissions.sh#L3 @nwolfe / @cthorn42

UPDATE: pe-puppetserver is actually setup a little different, so these changes are unnecessary there. puppetserver container will probably pick up some of those changes (around SSLDIR and correct VOLUME configuration), which will probably make these changes unnecessary here as well.

@Iristyle
Copy link
Contributor

@jay7x have you been configuring a different user to match one on the host system?

I'd be interested to hear some more details about your setup if you're able to share. Thanks!

@jay7x
Copy link
Author

jay7x commented Sep 24, 2019

@Iristyle yes, I was trying to setup dedicated puppet CA container with predictable UID/GID on host system. So I crafted passwd & group files and mapped them to the container's /etc. Actually just after that I realised "to be predictable" is good but not really required :-D
And then I hit into CPR-718..

@Iristyle
Copy link
Contributor

Iristyle commented Sep 24, 2019

I'm working on making some of the internal paths consistent with pe-puppetserver and therefore some of these locations may change. I'll unblock this PR when they're merged in.

@Iristyle
Copy link
Contributor

@jay7x we can merge this for now if you rebase / update your PR. We still want to do the path changes I mentioned, but that won't be happening for a bit since we don't have the bandwidth, and this is still a useful change I think?

@Magisus
Copy link
Contributor

Magisus commented Aug 14, 2020

We're updating our default branch name from master to 6.x, retargeting this.

@Magisus Magisus changed the base branch from master to 6.x August 14, 2020 16:20
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@justinstoller
Copy link
Member

We lost the thread on this. My apologies. I've created #2615 to provide the request but rebased onto main and done by someone who has signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants