Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Puppetfile should not be executable code #1136

Closed
binford2k opened this issue Mar 17, 2021 · 1 comment
Closed

The Puppetfile should not be executable code #1136

binford2k opened this issue Mar 17, 2021 · 1 comment
Labels

Comments

@binford2k
Copy link
Member

Right now the Puppetfile is arbitrary executed Ruby code. This can be dangerous, especially since some OSP users configure r10k to run as root. We should use parser or Ripper to parse the Puppetfile instead of just running it through instance_eval().

See #885 for a first attempt at this (using the AST directly).

@github-actions
Copy link

This issue has been marked stale because it has had no activity for 60 days. The Puppet Team is actively prioritizing existing bugs and new features, if this issue is still important to you please comment and we will add this to our backlog to complete. Otherwise, it will be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant