Fix showoff to work with new version of gli #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,3 +1,3 @@ | |||
| # No namespace here since ShowOff is a class and I'd have to inherit from | |||
| # Sinatra::Application (which we don't want to load here) | |||
| SHOWOFF_VERSION = '0.7.PL' | |||
| SHOWOFF_VERSION = '0.7.1' | |||
There was a problem hiding this comment.
Is this merging in 0.7.1 upstream?
If so, we should probably maintain that in the version number. eg, 0.7.1.PL or some such
|
I hit this today too on 10.8. This fix falls along the mainline showoff project's issue 192 --> schacon#192 |
|
Closing as the upstream patch has been merged |
op-ct
pushed a commit
to op-ct/showoff
that referenced
this pull request
Oct 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue of working with GLi >2.0.0