(maint) Update to PDK 1.6.0 with some basic checks #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 27, 2018 16:43
Prior to this commit the module was using pdk 1.4.1. This commit updates to PDK 1.6.0.
Prior to this commit there was an appveyor.yml and no other CI files. This commit adds a .sync.yml for PDK 1.6.0 and configures some basic tests for the module. The tests include a shellcheck option and enforce rubocop. There are no spec tests currently defined.
jarretlavallee
changed the title
jarretlavallee
changed the title
MartyEwings
approved these changes
Jun 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates to PDK 1.6.0 and adds some tests for Travis-CI. As we are still identifying what the testing platform will be, this is a minimal base testing. Acceptance testing using bolt and docker will probably be a long-term solution, but this PR is aimed at syntax and linting. This PR validates puppet lint, metadata, rubocop, and shellcheck in travis.
We will still need to identify a syntax and linting mechanism for powershell scripts. Possibly with PSScriptAnalyser using the powershell container or using appveyor.
As a follow-up item to this PR, travis will need to be enabled on this repo.