Add OpenTelemetry client instrumentation #108
Conversation
There was a problem hiding this comment.
At the very least, this should be opt-in 🙈 And it shouldn't exit on any failure raised by the telemetry class.
I'm not a huge fan of what this change means personally, and I feel like it would be worth letting people know how to disable it or opt in if it's off by default.
What's the reasoning behind adding tracking to this tool?
|
@briancain It will absolutely be opt it, full stop. The default functionality will be to emit nothing and to stay out of the way. The reasoning for this is that OpenTelemetry tracing has been added to VMPooler, NSPooler, and ABS and there is benefit in extending the trace information down to the initiating client. This PR is still a draft because I still have a good bit of work to do to make sure it works as intended and that it really does stay out of the way. This is the first client-side instrumentation I have worked on and the first for an app that can also be used as a library a la what is done in puppetlabs/beaker-abs#18. |
|
No problem at all @briancain! |
|
Just chiming in to say that getting this trace data should make debugging failed VM checkouts across Beaker to ABS to VMPooler/AWS/VSphere so much easier. I'm happy to see this work moving forward and looking forward to seeing how it evolves (even if I can't really see it in action anymore 😢🎻 ) That being said, I'd agree with @briancain that it should definitely be opt-in/no impact on users who don't want it, and that's how it looks to be configured currently. I'm sure @genebean is being very conscientious about user privacy here. ❤️ |
|
@genebean Happy to review this again whenever you're ready. |
|
@genebean Any progress here? |
Status
In Progress
Description
Add OpenTelemetry client instrumentation
Related Issues
Todos
Reviewers
@puppetlabs/dio
@highb
@briancain