Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird glitch on ROX-Filer 17w #1617

Open
rizalmart opened this issue Oct 15, 2019 · 10 comments
Open

Weird glitch on ROX-Filer 17w #1617

rizalmart opened this issue Oct 15, 2019 · 10 comments

Comments

@rizalmart
Copy link
Contributor

rizalmart commented Oct 15, 2019

When I click a disk image file which has a mimetype of application/x-img. This mimetype stored at /usr/share/applications/mimeinfo.cache only, filemnt is the default. But when I click the file, It returns an error message that "no run actions found" instead of running filemnt. However when I right click the file. The default app filemnt was shown on "Open With" menu. Also when I run ROX-Filer on terminal it shows on debug messages that only mimeapps.list path is shown, mimeinfo.cache is not shown. Is it glitch?

@wdlkmpx
Copy link
Contributor

wdlkmpx commented Oct 16, 2019

When it comes to opening a default app, rox only looks in it's own directories and mimeapps.list

If nothing is found, the run-action-helper is triggered and looks in mimeinfo.cache... if mimeinfo.cache lists the mimetype, only the relevant apps will be displayed. There's a button to show all installed apps (that are meant to be displayed in the menu).

If no desktop files are found in mimeinfo.cache, the helper displays all the installed apps (that are meant to be displayed in the menu).

"no run actions found" probably means something, you don't have the helper script and/or your rox Options file does not "reference" the helper script.

I quickly created this tarball with pCompress, a yad dialog created in 2014 inspired in file-roller/engrampa's dialog to create archives.. I'll probably add that script tomorrow. 230 lines.

Screenshot(8)

rox_config.tar.gz

Convert it to a pet package and "Install" rox_config and it should work. Perhaps the script and the whole rox_config should be part of the rox-filer package.

I know it should work. But the mime stuff is weird, I have a text file called locale.gen and it's identified as a Sega Genesis ROM, it doesn't make sense, I used that file to test this, manually adding and removing stuff from mimeinfo.cache.... sooo, it should work.

@wdlkmpx
Copy link
Contributor

wdlkmpx commented Oct 16, 2019

I guess I know where the glitch in the matrix comes from.

filemnt.desktop, has this line:

NoDisplay=true

Look at this:
https://github.com/puppylinux-woof-CE/woof-CE/blob/testing/woof-code/rootfs-packages/rox_config/usr/local/apps/ROX-Filer/open-with-mimeinfo.sh#L119

https://github.com/puppylinux-woof-CE/woof-CE/blob/testing/woof-code/rootfs-packages/rox_config/usr/local/apps/ROX-Filer/open-with-mimeinfo.sh#L126

I guess those lines can be removed, and many .desktop files should be fixed or something, so that the helper gtkdialog displays most icons.

@wdlkmpx
Copy link
Contributor

wdlkmpx commented Oct 16, 2019

Commit 8c99ca7 should fix this issue

I added application/x-genesis-rom=filemnt.desktop to mimeinfo.cache

And this is what I see when I click on /etc/locale.gen
Screenshot(9)

I clicked on More applications...
Screenshot(10)

After installing the rox_config.tar.gz file I attached to my previous message, replace /usr/local/apps/ROX-Filer/open-with-mimeinfo.sh with this file:

https://raw.githubusercontent.com/puppylinux-woof-CE/woof-CE/8c99ca7cedbee75d70cab7fd5dcb19fbc1ae5816/woof-code/rootfs-packages/rox_config/usr/local/apps/ROX-Filer/open-with-mimeinfo.sh

Make sure it's executable.

@wdlkmpx
Copy link
Contributor

wdlkmpx commented Oct 16, 2019

After commit 78f207c the run action helper ignores invalid desktop files

It think it will not work if you're not logged in as root. As the run action helper is a configuration option that is located in /root/.config/rox.source.........

We have a problem here, the same problem we see in jwm config. So the helper should be hard coded. I think it's "almost" finished, it can go in the rox-filer package.

You must be disappointed that /usr/local/apps/ROX-Filer/ROX/MIME is still there. It was deleted from rootfs-skeleton, but that directory is actually part of the rox-filer package

This will fix it.. but maybe a discussion must take place first:
puppylinux-woof-CE/rox-filer#2

There's stuff to fix .. rox-filer 18w will be interesting...

@rizalmart
Copy link
Contributor Author

I wonder if rox filer can be modified further to add menubar. The rox-filer menu was on the right click. Much better if the rox-filer menu was on the menubar and right-click contains file/folder option/menus only

@wdlkmpx
Copy link
Contributor

wdlkmpx commented Oct 16, 2019

I see what you mean. When a file/directory is selected, everything should be hidden but the dir/file context menu

A menubar would be quite handy indeed.

But I don't know if it's doable or the consequences of it (reaction). I can use rox as it is now... it has many pcmanfm keybindings, and with pCompress it will resemble even more pcmanfm with engrampa archiver integration.

Screenshot(11)

rox is too different, it's probably linuxified and freedesktoxified enough, but a redesign seems to be a lot of work, providing pcmanfm as an alternate filemanager seems to be the sensible thing to do.

Perhaps including openbox would be a good idea too, jwm lacks several features, but I see it as the Windows XP of the windows managers, it looks old and might have many bugs, but it just works, I don't see any substantial difference.. I use the same keybindings in jwm, openbox, microsoft windows, etc....

@wdlkmpx
Copy link
Contributor

wdlkmpx commented Oct 16, 2019

Commit e3b5526 adds pCompress with a .desktop file with only 1 mimetype: inode/directory.

pCrompress is a small sophisticated bash/yad script:
Screenshot(13)

Just like pcmanfm supports archiver integration so that you don't have to add hundreds of mimetypes to the desktop file, perhaps rox-filer should include code to properly integrate pCompress...

@rizalmart
Copy link
Contributor Author

Another bug found on your select default dialog. When I set it as the default app. It creates this wrong command

exec filemnt %f "$@"

It should be this one

exec filemnt "$@"

@wdlkmpx
Copy link
Contributor

wdlkmpx commented Oct 17, 2019 via email

@dimkr
Copy link
Contributor

dimkr commented Mar 22, 2021

Is this one fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants