Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable woof-CE branch #2191

Closed
dimkr opened this issue Mar 29, 2021 · 7 comments
Closed

Stable woof-CE branch #2191

dimkr opened this issue Mar 29, 2021 · 7 comments

Comments

@dimkr
Copy link
Contributor

dimkr commented Mar 29, 2021

Imagine a world where woof-CE has a branch ("stable", "release", whatever) that's synced with testing every once in a while (3/6/12 months) and the only changes pushed to it in between are bug fixes cherry-picked from testing.

This will make life easier for Puppy builders, and allow automated, periodic releases of Puppy updates (i.e. Slacko 8.0.1, 8.0.2 ...) with fixes from woof-CE plus security/bug fix updates from Slackware/Debian/Ubuntu.

@dimkr
Copy link
Contributor Author

dimkr commented Apr 21, 2021

@puppylinux-woof-CE/members @rizalmart @gyrog @zigbert (who did I miss?)

I can branch from testing now, set up automated periodic releases (slacko 7.0.1, 7.0.2 ...), cherry-pick fixes for severe issues from testing every once in a while (say, once a week or two), and set a deadline (half a year?) where this branch will be synced with testing to start another fixes-only period.

But for that to work, everyone will have to commit to:

  • Putting reasonable effort into minimizing changes when fixing a bug, to increase the chance of successful cherry-pick onto a branch that looks like testing from half a year ago
  • Fixing one bug in each commit
  • Separating bug fixes from other changes - i.e. a PR that adds a feature that depends on a bug fix will consist of two commits, so I can cherry-pick just the bug fix
  • Clear commit messages and/or documentation of bugs through GitHub issues (for example, the commit message can contain "Pupdial: Upgrade to version 2.0 package #1234" to refer to issue 1234) to explain and document what was fixed in a commit
  • Avoiding direct commits to testing and passing all changes in testing through PRs, to make it possible to go over recent changes in testing (= recently merged PRs) without looking at all commits one by one (it's easier to look at the commits grouped by feature/issue, rather than looking at hundreds of commits trying to find that one important bug fix commit)

dimkr added a commit that referenced this issue Oct 15, 2021
@dimkr
Copy link
Contributor Author

dimkr commented Oct 21, 2021

@dimkr dimkr closed this as completed Oct 21, 2021
@peabee
Copy link
Contributor

peabee commented Oct 21, 2021

@dimkr @01micko
What is the stable branch for?
Do I now need to decide whether to use the testing or stable branches for a build? How does this "make life easier for Puppy builders"?
How do I decide which branch to use?
And what is the purpose of the Master branch now??
Will all "Official Releases" now use the stable branch?

@peabee
Copy link
Contributor

peabee commented Oct 21, 2021

The readme seems to be inconsistent as it infers that the stable branch only applies to Vanilla DPup but then mentions Debian/Slackware/Ubuntu........

This is the stable branch, branched from testing on October 15th, 2021.

Its main purpose is to protect automated weekly builds of Vanilla Dpup from regressions and issues introduced in testing. Ideally, the only commits to this branch should be critical fixes cherry-picked from testing.

Currently supported: Build status

Slackware
Ubuntu
Debian

@dimkr
Copy link
Contributor Author

dimkr commented Oct 21, 2021

What is the stable branch for?

Quote from the README:

This is the stable branch, branched from testing on October 15th, 2021.

Its main purpose is to protect automated weekly builds of Vanilla Dpup from regressions and issues introduced in testing. Ideally, the only commits to this branch should be critical fixes cherry-picked from testing.

You can use it if don't want any new features introduced after October 15th.

I haven't changed anything else in the README, to make it easier to sync the branch with testing at some point in the future, then freeze it and only cherry-pick fixes for some time.

@peabee
Copy link
Contributor

peabee commented Oct 21, 2021

OK - so it does only apply to Vanilla DPup ................

@dimkr
Copy link
Contributor Author

dimkr commented Oct 21, 2021

No, you can use it. But I only cherry-pick fixes I find useful and safe for Vanilla Dpup. Sometimes they're dpup-specific fixes, but most are not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants