Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for nvme ssd drives for puppy-save files #1116

Merged
merged 1 commit into from Dec 10, 2017

Conversation

Mariappan
Copy link
Contributor

Fix for issue:
#1115

Rootcause:
In shutdownconfig, there is a if check to verify valid partitions. In that check, nvme* is not added, hence even if we select a valid partition with available space, not able to proceed.

Fix:
Added the nvme* in the 'if' check

@wdlkmpx
Copy link
Contributor

wdlkmpx commented Dec 9, 2017

This is something new. Actually several scripts might need the same patch, i can do that, but meanwhile can you paste the output of probepart and probedisk ?

@mavrothal
Copy link
Contributor

Do these drives show OK in puppy desktop?
There are other scripts that may need fixing too. probedisk, pup_event/prontend_{change,funcs}, rc.sysinit, clean_desk_icons, df, puppyinstaller and probably others.
Would be nice to have more comprehensive support/commit.

@Mariappan
Copy link
Contributor Author

Yes I have seen the need for this patch in her places too.
My knowledge in puppy linux is tooo low (today only installed as a recovery OS) and thought it would be better if someone who knows puppy linux fully to fix it completely.
I raised this pull request just to enable saving of puppy save files in nvm disk which will not harm any other funcitonality.

root# probepart
/dev/nvme0n1|none|1000215216
/dev/nvme0n1p1|ntfs|1003520
/dev/nvme0n1p2|vfat|1024000
/dev/nvme0n1p3|none|262144
/dev/nvme0n1p4|ntfs|485922816
/dev/nvme0n1p5|crypto_LUKS|419430400
/dev/nvme0n1p6|ext4|8388608
root# probedisk
root#

@wdlkmpx
Copy link
Contributor

wdlkmpx commented Dec 10, 2017

Ok thanks. I identified the scripts that need to be patched and that includes the init scripts, the pup_event* rox scripts and pup_event_frontend.bac...

I'll do that in the following days..

Anybody volunteer to rewrite pup_event_frontend.bac in C?

@wdlkmpx wdlkmpx merged commit c948d7d into puppylinux-woof-CE:testing Dec 10, 2017
@Mariappan Mariappan deleted the fix_nvme_ssd_save branch December 10, 2017 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants