Add optional support for building missing packages from source in 3builddistro #1984
Conversation
… into feature/rootfs-packages-builder-v2
rc.update does a bunch of stuff so probably safer just to do what's needed only. |
… into feature/rootfs-packages-builder-v2
|
I've marked this PR as ready for review+merge to make life easier for all developers who use this branch. Maybe, the best way to fix slacko/dpup specific issues and complete the GTK 3 migration (e.g. sfs_load) is after merging this. Also, I have some concerns about backwards-compatibility. For example, how to handle gtkdialog based packages people download from the forums, that won't get fixed as part of this change in woof-CE (list, table, and combobox are gone). Maybe we'll need two packages, gtkdialog/gtkdialog-gtk3, and upgrade all woof-CE stuff that works to use the latter, and gradually fix brkoen stuff like sfs_load. EDIT: is it really that bad? Maybe I'm searching for broken stuff the wrong way, or the list is really that short. Replacing list and table with tree should be very easy, and it's only two PPM dialogs, frisbee, pschedule and sfs_load. |
|
Well... the only way to fix bugs is to get more eyes looking! 👓 The pair of us, as far as I know, there could be some sand baggers, can only find so much. |
|
At least 1 addition needs to be made. A commented block for petbuilds in When merged I am going to add slacko64-15 support. I have been building out of If you don't mind updating the ci job for that and making an iso release once a week I'd be grateful. Thanks |
1 similar comment
|
At least 1 addition needs to be made. A commented block for petbuilds in When merged I am going to add slacko64-15 support. I have been building out of If you don't mind updating the ci job for that and making an iso release once a week I'd be grateful. Thanks |
Totally agree. It's a community project, we have bugs, and the right thing to do is to have a faster release and feedback loop.
I'll do that. Less manual work for you means more effort that goes into making slacko and woof-CE better, and for the first time in Puppy's history, the ability to release minor releases with security updates and woof-CE fixes. |
|
Github site is down for me ATM. Feel free to merge with my requested
addition to `woof-code/_00build.conf`
I have also a crude fix for `/usr/lib/gtkdialog/box_splash` to get back the
color splash messages. Patch to follow when github is back up for me.
…On Sat, Feb 20, 2021 at 7:29 AM Dima Krasner ***@***.***> wrote:
Well... the only way to fix bugs is to get more eyes looking!
Totally agree. It's a community project, we have bugs, and the right thing
to do is to have a faster release and feedback loop.
If you don't mind updating the ci job for that and making an iso release
once a week I'd be grateful. Thanks
I'll do that. Less manual work for you means more effort that goes into
making slacko and woof-CE better, and for the first time in Puppy's
history, the ability to release minor releases with security updates and
woof-CE fixes.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1984 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHYZ347S3TBDF5NCA4FWGTS73J47ANCNFSM4VQDEJZQ>
.
|
|
Back up now... but thinking about my patch it could be more global for @zigbert 's gtkdialog themes. Here it is anyway. (and there probably is a better way)
--- box_splash.orig 2020-07-09 08:32:28.000000000 +1000
+++ box_splash 2021-02-20 08:12:30.703145948 +1000
@@ -247,7 +247,27 @@ else
fi
#gtk-theme
-gtkrc='
+if ldd $(which gtkdialog) | grep -iq 'gtk\-3' ; then #gtk3
+ ORIG_XDG=$XDG_CONFIG_HOME
+ [ -d /tmp/gtk3-theme/gtk-3.0 ] || mkdir -p /tmp/gtk3-theme/gtk-3.0
+ export XDG_CONFIG_HOME=/tmp/gtk3-theme
+ bgcolor=$bg
+ fontsize=$fontsize
+ [ "$bgcolor" ] || bgcolor=gray90
+ [ "$fontsize" ] || fontsize=40
+ cat > /tmp/gtk3-theme/gtk-3.0/gtk.css <<_THEME
+@define-color bg_color $bgcolor;
+
+* {
+ background-color: @bg_color;
+ color: $fg;
+ font-size: ${fontsize}px;
+}
+
+_THEME
+
+else #gtk2
+ gtkrc='
pixmap_path "/tmp"
style "gtkdialog-splash"
{
@@ -270,8 +290,9 @@ style "font"
fg[NORMAL]="'$fg'"
}
class "GtkLabel" style "font"'
-echo $gtkrc > /tmp/gtkdialog-splash_gtkrc
-export GTK2_RC_FILES=/tmp/gtkdialog-splash_gtkrc
+ echo $gtkrc > /tmp/gtkdialog-splash_gtkrc
+ export GTK2_RC_FILES=/tmp/gtkdialog-splash_gtkrc
+fi
#process close of window, default is mouseover...
CLOSETAG1=''
@@ -329,3 +350,4 @@ while [ $timeout -ne 0 ];do #100604
done
kill $dlgPID
echo 'EXIT="Exit on timeout"'
+[ ! "$XDG_CONFIG_HOME" = "$HOME/.config" ] && export XDG_CONFIG_HOME=$ORIG_XDG
|
|
|
|
Merging and dealing with the fallout later. I'll fix what I can today. |
|
Wow! PMaterial has the speaker icons!!! 🥇
It has given me motivation (at some point) to update the 3 native icon themes to gtk+3 standard. Btw, ci build is in progress (exactly as screeny). |
|
Pretty awesome that in qemu I can find the host samba share, load the devx and compile stuff too :-) |
|
Haha.. chewing up some MS server space now (hehe)
.. and just because I can .. ( 👅 )
.. and to be fair Firefox (though I love vivaldi - I actually have contatct with one of the devs Ruari Oedegaard - he was at Opera and sent me insider previews when Opera was good in the presto days) - still a fan of Firefox though -- only other browser I like is Falkon (KDE - formerly Qupzilla), and of course all the really light ones like Netsurf, Dillo, Links, Lynx et al.
Too much fun! I have to stop it! But... this tune is reflecting my mood -- some nice soothing jazz 😎
|
samba gui is a temporary fix and will be included in the next slacko samba build. re #1984
|
It's out there slacko64-8.0 |
|
Wow wow wow. Merging this PR was a very brave move, and I'm super thankful. The GTK 3 adoption is a huge step forward for Puppy IMHO 😄 I'll start working on cleanup of ROX-Filer. I did a rough GTK 3 port without the pinboard and the icon view, but I'm going to restart my work. This time, I'll clean up the use of widgets, etc' that are deprecated in GTK 2, release one version and make sure it's stable, then start gradual migration to GTK 3, which should be easy if the GTK 2 version doesn't use anything that's deprecated in GTK 2 and finally removed in GTK 3. |
Fortune favours the brave? It's natural evolution and thanks for giving me a push 😉 😉 |
|
Just for the record, I'm still get grief with
|
Maybe PKG_CONFIG_PATH needs to be set before building xdg-puppy. Do you still have the build log? |
|
No, but should be reproducible - soon |
|
Here The complete 3builddistro log - just for curiosity |
Can cross-compile ARM packages on x86_64, thanks to #1969!
@sc0ttj @01micko @peabee What do you think about this feature? I find it much easier to build packages directly from woof-CE (with cache, of course, so it doesn't happen in every 3builddistro), instead of having to manage a repo.
Extra packages (= not pre-installed ones) can be handled by the petbuilds repo, of course, and I think we can set up a CI/CD flow in GitHub Actions that builds all PET packages, then pushes a GitHub release that contains .pet packages plus the Packages-* file (all pet.specs, concatenated), and use the latest release URL as a PET repo.