Make PPM safer to use when using overlay (fixes #3188) #3317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimkr
force-pushed
the
bugfix/ppm-overlay
branch
from
762c8eb
to
1cee1fb
Compare
01micko
approved these changes
Aug 13, 2022
dimkr
force-pushed
the
bugfix/ppm-overlay
branch
from
1cee1fb
to
dc35a99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modification of lower layers leads to undefined behavior under overlay, so applications must be installed to / and removed from /. This ensures whiteout files in pup_rw are created correctly, and snapmergepuppy.overlay synchronizes the installed/removed package to pup_ro1.
In addition to the extra safety, it's nice to be able to install or remove a package and reboot without saving the changes if you regret what you did.