Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is_mbp is always empty #3443

Merged
merged 1 commit into from
Oct 2, 2022
Merged

Conversation

dimkr
Copy link
Contributor

@dimkr dimkr commented Sep 30, 2022

@rizalmart Maybe that's not the only bug introduced?

Whoa, it's been this way since 66b42e6 @wdlkmpx

If this entire thing is broken since at least 2018 (= never worked) and nobody complains, maybe it's a better idea to just remove it? Fixing something broken for years can introduce new issues with today's kernels, and maybe it's not needed anymore. EDIT: see #3447.

@dimkr dimkr changed the title is_mbp is always empty since eccdaa2 is_mbp is always empty Sep 30, 2022
@mavrothal
Copy link
Contributor

Suppose to be empty unless puppy is running on a MacBookPro retina.
Did you try it on a macbookpro?

@dimkr
Copy link
Contributor Author

dimkr commented Oct 2, 2022

Suppose to be empty unless puppy is running on a MacBookPro retina. Did you try it on a macbookpro?

But it's always empty, even on one of these Macs.

-q means:

       -q, --quiet, --silent
              Quiet; do not write anything to standard output.

So if [ "$is_mbp" ] ; then is always false, on any hardware.

See #3447 (comment).

@mavrothal mavrothal merged commit b77c223 into puppylinux-woof-CE:testing Oct 2, 2022
@dimkr dimkr deleted the bugfix/never-mbp branch October 2, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants