Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline common values #24

Closed
felixSchl opened this issue Sep 26, 2018 · 1 comment
Closed

Inline common values #24

felixSchl opened this issue Sep 26, 2018 · 1 comment
Assignees
@felixSchl
Labels
enhancement New feature or request optimization performance
Projects
Optimizations

Comments

@felixSchl
Copy link
Collaborator

Implement something akin to:

https://github.com/purescript/purescript/blob/a8e0911222f46411776978a13866eb097175162c/src/Language/PureScript/CoreImp/Optimizer/Inliner.hs#L83-L107

We could further modify the AST to unbox values based on the operation being taken (thus erasing the intermediate purs_any_t altogether for e.g. addition etc.).
@felixSchl felixSchl mentioned this issue Sep 26, 2018
Closed
@felixSchl felixSchl added this to To do in Optimizations Oct 3, 2018
@felixSchl felixSchl self-assigned this Oct 8, 2018
@felixSchl felixSchl changed the title Inline operators Inline common values Oct 10, 2018
@felixSchl
Copy link
Collaborator Author

The issue was mistitled and was referring to the inlineCommonValues pass, which has been implemented, thus closing. Opening a new issue dedicated to inlineCommonOperators which is a bit more involved.

Optimizations automation moved this from To do to Done Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felixSchl felixSchl

Labels
enhancement New feature or request optimization performance
Projects
Optimizations
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@felixSchl