Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons module: Consider adding small amount of border-radius. #4

Closed
jconniff opened this issue May 13, 2013 · 4 comments
Closed

Buttons module: Consider adding small amount of border-radius. #4

jconniff opened this issue May 13, 2013 · 4 comments
Labels
Milestone

Comments

@jconniff
Copy link
Contributor

The new buttons are flat (gradient-less) and square cornered. Have we gone too far in the pursuit of "flatness"? Do we need some affordance that these are buttons, before the user interacts with them? Round corners (small border-radius) on buttons seems like a helpful clue that they are buttons (clickable) and not colored banners, tags, or pills.

@ericf
Copy link
Collaborator

ericf commented May 13, 2013

Round corners (small border-radius) on buttons seems like a helpful clue that they are buttons (clickable) and not colored banners, tags, or pills.

+1 I realized this recently when working on a website, I set the border-radius: 2px and it made the buttons feel "clickable"

@ericf
Copy link
Collaborator

ericf commented May 23, 2013

@tilomitra I think we should do this for v0.1.0.

@jconniff
Copy link
Contributor Author

@tilomitra @ericf I saw this issue tagged as a bug and added 2px of border-radius in the template in Skin Builder in anticipation of it being fixed.

@tilomitra
Copy link
Contributor

Pull Request: #18

tilomitra added a commit to ericf/pure that referenced this issue May 24, 2013
@ericf ericf closed this as completed May 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants