Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update forms.css #133

Merged
merged 5 commits into from
Jul 17, 2013
Merged

Update forms.css #133

merged 5 commits into from
Jul 17, 2013

Conversation

AurelioDeRosa
Copy link
Contributor

Proposed fix for issue #109

Proposed fix for issue #109
@tilomitra
Copy link
Contributor

Thanks! Can you add a commit for the HISTORY.md?

@tilomitra
Copy link
Contributor

Could you also update the manual test page for rounded inputs with a textarea to make sure we capture the other selector? Something like this:

<form class="pure-form pure-form-stacked">
       <input type="text" class="pure-input-rounded">
       <textarea class="pure-input-rounded" rows='5' cols='40'></textarea>
       <button type="submit" class='pure-button pure-input-rounded'>Search</button>
</form>

@AurelioDeRosa
Copy link
Contributor Author

All done. However, I think that now rounded <input>s need a margin. Look at how they'll look without the <label>s

@tilomitra
Copy link
Contributor

@AurelioDeRosa I see the issue. Are you suggesting that we add a negative margin-left to the inputs? If so, I agree. Feel free to do that and I'll merge this in.

@AurelioDeRosa
Copy link
Contributor Author

Honestly, I don't see any problem with the left margin. I was talking about bottom (or top) margin. Look at this screenshot that shows the form without labels:

image

@tilomitra
Copy link
Contributor

@AurelioDeRosa You're right. I added this to line 150 of forms.css:

    margin: 0.25em 0;

The 0.25em top/bottom = 0.5em between inputs, which is the same as the pure-form-aligned margin. Do you want to add this in as a commit to this pull request?

Edit: I can send you a PR against your branch, but it may be faster for you to just add this line in.

@AurelioDeRosa
Copy link
Contributor Author

I agree with your change, it seems perfect. I commit this change so you can now merge all. Thank you @tilomitra!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants