Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML5 <menu> element support. #196

Closed

Conversation

rafalwrzeszcz
Copy link

Added support for <menu> element for Menu module.

@ericf
Copy link
Collaborator

ericf commented Sep 27, 2013

@tilomitra this makes sense to me, do you want to incorporate <menu> element support into your Menus revamp work?

@jamesalley
Copy link
Contributor

This is a good PR, but I'm going to close it because it's no longer relevant given the new Menu, which uses low-specificity selectors based on classnames instead of <ul> or <menu> elements.

In the not-too-distant future, I may drop support for Menu from Pure (breaking it out into a new component library, perhaps); the styling of a menu is just too varied and too opinionated to belong in Pure.

@jamesalley jamesalley closed this Jan 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants