Adds a Sized Button Test #272
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This demonstrates the button sizing discrepancy reported in issue #271. Anchor buttons with explicit widths (`pure-input-1*`) contained in forms are too wide and break out of containing boxes. This seems to be a result of left and right padding being applied on top of the defined width.
|
Hey, thanks for the PR! We're actually planning on removing We're currently doing a bunch of work on making Pure and its website mobile-first. Once this new grids work lands, we will update forms to use the new grid system and remove all I'm going to hold off on merging in this PR since these things will be getting removed from core soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This demonstrates the button sizing discrepancy reported in issue #271. Anchor buttons with explicit widths (
pure-input-1*) contained in forms are too wide and break out of containing boxes. This seems to be a result of left and right padding being applied on top of the defined width.The anchor button is too wide:
I'm putting this in a separate pull request from my proposed solution.