Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow click and drag to select multiple connections and revise "shift" #2221

Open
porres opened this issue Mar 15, 2024 · 6 comments
Open

allow click and drag to select multiple connections and revise "shift" #2221

porres opened this issue Mar 15, 2024 · 6 comments
Labels
improvement improves an existing functionality without adding new features subject:patching things concerning the patching workflow ("intelligent patching")

Comments

@porres
Copy link
Contributor

porres commented Mar 15, 2024

So far you cannot select multiple connections.

Click on an empty spot and drag only selects boxes (and their connections). There is no way to only select cords. So one request would be to be able to click and drag to select just cords/connections.

For boxes, we're allowed to select multiple and individual items with "shift+click", but this is not possible with cords, as it just swaps connection. I think it makes sense to be able to select more than one cord with shift+click and we can use a different key, like 'alt+click' to 'alternate' and swap connections.

Being able to select multiple connections is nice to delete more than one at a time.

@umlaeute
Copy link
Contributor

The current data structures only have a single int (the index of the connection).
Since the structure is semi-private, changing this might break binary compat.

Apart from that, I don't see much point on being able to select more than one connections at a time: the argument that one can then delete multiple connections seems especially weak. (The annoying part is that you have to select the connections, not that you have to press Delete).
The only nice thing about deleting them at once is being able to undo all of them with a single keystroke, but I'm not convinced that this warrants breaking binary compat.

@porres
Copy link
Contributor Author

porres commented Mar 15, 2024

think of unpack and pack with a zillion connections and you want to disconnect them all. Now you can select one or another and break all connections for either, but say you chose unpack and don't want to loose its input connection. There's no way to do this currently and I've seen myself desiring for such a thing.

@umlaeute
Copy link
Contributor

yes, but your solution is basically doing Shift+Click a zillion times and then do a Delete.
i don't see this as significantly better than doing Click-Delete a zillion times.

so what is the point?

@porres
Copy link
Contributor Author

porres commented Mar 15, 2024

yes, but your solution is basically doing Shift+Click a zillion times

not really, I also suggested that we could be able to click and drag to make a rectangular selection that only includes patch cords. There is no way to do that yet.

Shift+click would be also useful, but for two or three (not a zillion) connections that cannot be singled out by a rectangular selection

@Spacechild1
Copy link
Contributor

Spacechild1 commented Mar 15, 2024

The description is a bit confusing. I think there are actually two requests:

  1. allow to click and drag to select just cords/connections.
  2. select several cords with shift + Click

I think 1. would definitely make sense from a UX point of view (though I have no idea how hard it would be to implement).

I agree that Shift+click is not really necessary, but together with 1. it would be more consistent. If I can drag my mouse to select something, I also expect Shift+Click to (de)select individual elements.

@umlaeute
Copy link
Contributor

indeed i missed the drag-selecting of connections.

@umlaeute umlaeute added subject:patching things concerning the patching workflow ("intelligent patching") improvement improves an existing functionality without adding new features labels Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement improves an existing functionality without adding new features subject:patching things concerning the patching workflow ("intelligent patching")
Projects
None yet
Development

No branches or pull requests

3 participants