-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pdcontrol updates #828
base: master
Are you sure you want to change the base?
pdcontrol updates #828
Conversation
@porres could you prepend an atom to the output of so we get:
And we can use a [route version] What do you think? EDIT: no forget it it's no a good idea. :) |
yeah, in order to use [route version] we need the output to start with 'version' instead of list, and [pdcontrol] doesn't really send tagged data to tell you what you asked for, so it'd be a special case as an odd one out. I guess the idea is that you know what you're asking to [pdcontrol] so you know what you're getting. And if you want different things from [pdcontrol] you have to use more than one. |
i agree with @porres. |
this is a "flavour" symbol and may allow pd forks to put their own symbol and then we can detect not only the version but the flavour.
update help file to include info on flavour, last one was to solve a conflict
trying to solve conflict again
as long as this doesn't have conflicts, I can update the help file later, I'm always strugglng on solving conflicts :( |
yeah, with all the doc updates I did I'm having to solve many conflicts in lots of old PRs of mine. I don't know why this now fails in one of the checks, same thing happened to another PR but not all... I just put the original help file from master and didn't change the code |
The CI check_file_permissions output is pretty clear: src/x_gui.c |
sorry I didn't read it :/ I was just surprised that I hadn't touched the code, but then, maybe this check was added later and my old mistake just wasn't caught before ;) there's also another error on another PR that I made the same conflict resolving but read the error and it wasn't this at all... so that remains a mystery. thanks |
1st commit ( 036fe41 ) closes #803
2nd commit ( f4816e9 ) closes #819
commits 31d2931 and 31d2931 close #1027
8ed7ee6 closes #928